On Tue, 04 Jan 2011 17:34:29 -0800
Rick Jones [off-list ref] wrote:

quoted

quoted

quoted

Since this is a boolean it SHOULD go into ethtool_flags rather than
being a high level operation.

It could do, but I though ETHTOOL_{G,S}FLAGS were intended for
controlling offload features.

It just seems the number of hooks keeps growing which takes more space
and increases complexity.

Is there any complication/downside to using flags in the (un?)likely event of 
wanting different flavors of loopback in the card?

rick jones

Then let is keep it as command and have a parameter to set mode.
There might be drivers that want to loopback in SW, HW, PHY or even switch.

--