Thread (29 messages) flat view 29 messages, 8 authors, 2011-01-23

Re: [PATCH v2] net: Allow ethtool to set interface in loopback mode.

From: Rick Jones <hidden>
Date: 2011-01-05 01:34:33

quoted
quoted
Since this is a boolean it SHOULD go into ethtool_flags rather than
being a high level operation.
It could do, but I though ETHTOOL_{G,S}FLAGS were intended for
controlling offload features.

It just seems the number of hooks keeps growing which takes more space
and increases complexity.
Is there any complication/downside to using flags in the (un?)likely event of 
wanting different flavors of loopback in the card?

rick jones
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help