Thread (20 messages) 20 messages, 4 authors, 2010-09-19

Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment

From: Eric Dumazet <hidden>
Date: 2010-08-31 13:13:38
Also in: lkml

Le mardi 31 août 2010 à 20:36 +0800, Herbert Xu a écrit :
On Tue, Aug 31, 2010 at 11:17:51AM +0200, Eric Dumazet wrote:
quoted
Once again, the IP stack -> bridge -> IP stack flow bites us,
because bridge likes to dirty IPCB.
OK, so we're talking about a locally transmitted packet, with
IP options leaving the IP stack, entering bridging, and then
reentering the IP stack?

In that case the packet should no longer be treated as an IP
packet when it enters the bridge.  So if it did have options
and we want to support that in bridging then we need to parse
IP options there as my comment suggested.
Bandan did not provide a full stack trace,
but I believe the problem was :

br_nf_dev_queue_xmit() -> ip_fragment -> icmp_send() ->
ip_options_echo() : crash, because ip_options_echo take bridge CB as
IPCB data.

http://www.spinics.net/lists/netdev/msg139370.html



Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help