Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2010-08-31 08:24:57
Also in:
lkml
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2010-08-31 08:24:57
Also in:
lkml
On Tue, Aug 31, 2010 at 07:20:31AM +0200, Eric Dumazet wrote:
Le lundi 30 août 2010 à 19:21 -0400, Bandan Das a écrit :quoted
quoted
I wonder if we want this. Maybe setting skb->local_df = 1 in bridge should be enough ?Thanks Eric for looking at this. Indeed, setting local_df to 1 seems to be enough! I will respin and post a different patch.Reading this stuff again, I wonder if we should not revert commit 17762060c25590bfddd and use a different trick
I don't quite understand the problem. Does the packet actually have IP options? If not why is it trying to look at IP options? If it does have options, then we should parse options in the bridge driver before passing it to the IP stack (or just drop the packet). Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt