Thread (15 messages) 15 messages, 4 authors, 2010-08-27

Re: [PATCH net-next-2.6] gro: __napi_gro_receive() optimizations

From: Eric Dumazet <hidden>
Date: 2010-08-25 20:54:39

Le mercredi 25 août 2010 à 13:45 -0700, Stephen Hemminger a écrit :
On Wed, 25 Aug 2010 22:33:51 +0200
Eric Dumazet [off-list ref] wrote:
quoted
compare_ether_header() can have a special implementation on 64 bit
arches if CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is defined

__napi_gro_receive() can avoid a conditional branch to perform device
match.

__napi_gro_receive() can be used from vlan_gro_common() instead of being
duplicated.

Signed-off-by: Eric Dumazet <redacted>
Please, 2 patches. not mixing unrelated bits in one patch.

Well, all this stuff was added in a single commit, 

commit aa4b9f533ed5a22952e038b9fac2447ccc682124
Author: Herbert Xu [off-list ref]
Date:   Sun Feb 8 18:00:37 2009 +0000

    gro: Optimise Ethernet header comparison


But yes, I guess I can cook three different patches, if you feel its
better this way...


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help