Re: [Uclinux-dist-devel] [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level>
From: Mike Frysinger <hidden>
Date: 2010-07-28 15:36:58
Also in:
lkml
On Wed, Jul 28, 2010 at 06:00, Joe Perches wrote:
On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote:quoted
On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote:quoted
$ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" total: 2 errors, 25 warnings, 1723 lines checked $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" total: 0 errors, 0 warnings, 1743 lines checkedi dislike the mixing of whitespace and useful changes if they were split, and they worked, then i wouldnt have a problem with themIs that a nak or a dislike?
if you arent going to bother fixing things, then i guess it's a NAK ;)
Also, is Michael Hennerich actually the maintainer for bfin_mac? He had been listed as MAINTAINER for over a year but he hasn't ever written or acked a patch for this file.
i dont know what log you're reading, but i see Michael making plenty of changes to this driver -mike