Joe Perches wrote on 2010-07-28:

On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote:

quoted

On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote:

quoted

$ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:"
total: 2 errors, 25 warnings, 1723 lines checked $
./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:"
total: 0 errors, 0 warnings, 1743 lines checked

i dislike the mixing of whitespace and useful changes if they were
split, and they worked, then i wouldnt have a problem with them

Is that a nak or a dislike?

I think what Mike meant was - two patches would be better.
I'm currently cloning the tree this patch applies to.
I'll ACK once I verified the patch.

Also, is Michael Hennerich actually the maintainer for bfin_mac?
He had been  listed as MAINTAINER for over a year but he hasn't ever
written or acked a patch for this file.

commit making Michael Hennerich bfin_mac MAINTAINER $ git log -1
6c83429a commit 6c83429a1c32c914dfb81939cc2ddece97e48294
Author: Mike Frysinger [off-list ref]
Date:   Sun May 24 02:13:15 2009 -0400

    MAINTAINERS: update Blackfin items

    With Bryan Wu having moved on to another job, push the slack onto
    some other ADI lackeys.

    Signed-off-by: Mike Frysinger [off-list ref]
$ ./scripts/get_maintainer.pl -f drivers/net/bfin_mac.c \
      --rolestats --git-since=5-years-ago --nol Michael Hennerich
[off-list ref] (supporter:BLACKFIN EMAC DRIVER) "David
S. Miller" [off-list ref] (commit_signer:41/65=63%) Jeff Garzik
[off-list ref] (commit_signer:31/65=48%) Bryan Wu
[off-list ref] (commit_signer:26/65=40%) Mike Frysinger
[off-list ref] (commit_signer:20/65=31%) Sonic Zhang
[off-list ref] (commit_signer:8/65=12%)

Greetings,
Michael

Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif