Thread (61 messages) 61 messages, 7 authors, 2010-07-28

Re: [PATCH 0/2] Support untagged symlinks to tagged directories.

From: Eric W. Biederman <hidden>
Date: 2010-07-21 20:20:50

Greg KH [off-list ref] writes:
On Tue, Jul 20, 2010 at 10:08:27PM -0700, Eric W. Biederman wrote:
quoted
Greg KH [off-list ref] writes:
quoted
On Mon, Jul 19, 2010 at 01:34:51PM -0700, Andrew Morton wrote:
quoted
On Thu, 8 Jul 2010 16:06:01 -0700
Greg KH [off-list ref] wrote:
quoted
On Thu, Jul 08, 2010 at 03:28:53PM -0700, Eric W. Biederman wrote:
quoted
Greg KH [off-list ref] writes:
quoted
With this patch, how does the existing code fail as the drivers aren't
fixed up?

I like this change, just worried it will cause problems if it gets into
.35, without your RFC patch.  Will it?
geethanks!

On the FC6 test box I have no networking.
Ick.

Eric, any ideas?
Yes.  I just found some time to test my fixes and things are looking
good.  It really is just two one line fixes.

On the other part of this debug with SYSFS_DEPRECATED enabled it
with mac80211_hwsim drivers works fine no problems.  I expect the
bnep driver will also be fine.

What is affecting those two is arguably a bug in the non-deprecated
sysfs mode.

Regardless here are my fixes.  I have split this into a patch for
the warning and a patch for sysfs_delete_link.  Because at least
the sysfs_delete_link code needs to make into 2.6.35 if we can.
Do these patches obsolete the existing one I have in my tree entitled:
	Subject: sysfs: Don't allow the creation of symlinks we can't remove
or are they on top of that one?
No. These patches are incremental on top of what you have.

In particular patch 1 fixes what is in 2.6.35-rc5, and patch 2
fixes the additional check in:
'sysfs: Don't allow the creation of symlinks we can't remove'

Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help