Re: [PATCH] sysfs: Don't allow the creation of symlinks we can't remove

On Mon, Jul 19, 2010 at 01:34:51PM -0700, Andrew Morton wrote:

On Thu, 8 Jul 2010 16:06:01 -0700
Greg KH [off-list ref] wrote:

quoted

On Thu, Jul 08, 2010 at 03:28:53PM -0700, Eric W. Biederman wrote:

quoted

Greg KH [off-list ref] writes:

quoted

With this patch, how does the existing code fail as the drivers aren't
fixed up?

I like this change, just worried it will cause problems if it gets into
.35, without your RFC patch.  Will it?

It don't expect this patch to be worse than where we are current at.
Network devices are renamed, and come and go enough that both the
mac80211_hwsim and the bnep driver are currently unusable with a
failure only the rename and remove.

This patch simply moves the failure into creation where we are a little more
prepared to deal with problems, and this patch is limited to mac80211_hwsim,
bnep, and any hypothetically undiscovered other network devices that
have the same problem.

mac80211_hwsim with just this patch becomes somewhat usable as it's primary
network device gets registered and the module can be loaded and unloaded.  It
just doesn't create the wlan0 and wlan1 interfaces for the wifi interfaces.

Fair enough, I've commited it now, let's see what happens :)

geethanks!

On the FC6 test box I have no networking.

Ick.

Eric, any ideas?