Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_lock_irqsave in ax_interrupt
From: David Miller <davem@davemloft.net>
Date: 2010-07-11 02:49:15
From: David Miller <davem@davemloft.net>
Date: 2010-07-11 02:49:15
From: Ben Hutchings <redacted> Date: Sun, 11 Jul 2010 03:46:28 +0100
On Sat, 2010-07-10 at 20:18 +0900, Ken Kawasaki wrote:quoted
axnet_cs: use spin_lock_irqsave instead of spin_lock in ax_interrupt[...] I assume this is because it's now called from ei_watchdog() and not only from interrupt context. Perhaps you should explain that in the commit message.
No, interrupt handlers in general may not assume that interrupts are off or on when they are invoked. Therefore they must use irqflags saving/restoring.