Re: [PATCH kernel 2.6.34-rc5] lib8390: to be SMP safe
From: Ken Kawasaki <hidden>
Date: 2010-05-06 20:48:17
Sorry, I cancel this patch and test it again. Best Regards Ken
quoted hunk ↗ jump to hunk
lib8390: write the value "ENISR_ALL" to register "EN0_IMR" after enable_irq_lockdep_irqrestore. This patch avoids frequent transmit error on SMP system. Signed-off-by: Ken Kawasaki <redacted> ------ linux-2.6.34-rc6/drivers/net/lib8390.c.orig 2010-05-02 16:49:57.000000000 +0900 +++ linux-2.6.34-rc6/drivers/net/lib8390.c 2010-05-02 18:09:18.000000000 +0900@@ -367,9 +367,9 @@ static netdev_tx_t __ei_start_xmit(struc dev->name, ei_local->tx1, ei_local->tx2, ei_local->lasttx); ei_local->irqlock = 0; netif_stop_queue(dev); - ei_outb_p(ENISR_ALL, e8390_base + EN0_IMR); spin_unlock(&ei_local->page_lock); enable_irq_lockdep_irqrestore(dev->irq, &flags); + ei_outb_p(ENISR_ALL, e8390_base + EN0_IMR); dev->stats.tx_errors++; return NETDEV_TX_BUSY; }@@ -407,10 +407,10 @@ static netdev_tx_t __ei_start_xmit(struc /* Turn 8390 interrupts back on. */ ei_local->irqlock = 0; - ei_outb_p(ENISR_ALL, e8390_base + EN0_IMR); spin_unlock(&ei_local->page_lock); enable_irq_lockdep_irqrestore(dev->irq, &flags); + ei_outb_p(ENISR_ALL, e8390_base + EN0_IMR); dev_kfree_skb (skb); dev->stats.tx_bytes += send_length;