Re: [PATCH] mac8390: change an error return code and some cleanup, take 4
From: David Miller <davem@davemloft.net>
Date: 2010-05-31 15:14:07
Also in:
linux-m68k, lkml
From: David Miller <davem@davemloft.net>
Date: 2010-05-31 15:14:07
Also in:
linux-m68k, lkml
From: Joe Perches <joe@perches.com> Date: Mon, 31 May 2010 08:08:13 -0700
There are many uses of KERN_DEBUG that are reasonable to have always enabled.
Doubtful. pr_debug() makes a ton of sense as currently implemented. It's for messages that we want both compile time and run-time control over. The case we have here in mac8390 seems like it should stay as pr_info(). Because 1) it's already controlled by a run-time knob so controlling it even further is confusing and 2) the message is "informative", it lets the user know a feature cannot be enabled, thus pr_info().