Re: [PATCH] sky2: receive dma mapping error handling
From: Jarek Poplawski <hidden>
Date: 2010-02-01 10:47:34
Also in:
lkml
From: Jarek Poplawski <hidden>
Date: 2010-02-01 10:47:34
Also in:
lkml
On Sun, Jan 31, 2010 at 11:26:03PM -0500, Michael Breuer wrote:
FYI - tried generating lots of extra tx traffic... found a way to
generate the rx status messages on demand:
ping -i .0000001 -s 8000 -t 2 <host> >/dev/null
Yields:
Jan 31 23:08:07 mail kernel: sky2 eth0: rx error, status 0x1f6a0010
length 1518...
Jan 31 23:08:12 mail kernel: net_ratelimit: 316 callbacks suppressed etc.
...
Understanding that the other side is out of spec, I'd still wonder why the sky2 driver generates rx errors. Perhaps overruns should be tossed silently... by the hardware if possible.
Of course it's a matter of taste, but it seems such errors shouldn't be tolerated in a local network. I'd rather prefer doing them more explicit (like e.g. some other kind of length errors). Jarek P.