Re: [PATCH] sky2: Fix WARNING: at lib/dma-debug.c:902 check_sync
From: Jarek Poplawski <hidden>
Date: 2010-01-21 21:02:35
Also in:
lkml
On Thu, Jan 21, 2010 at 03:46:50PM -0500, Michael Breuer wrote:
On 1/21/2010 3:41 PM, Jarek Poplawski wrote:quoted
On Thu, Jan 21, 2010 at 02:59:19PM -0500, Michael Breuer wrote:quoted
Test notes: 1) Warning previously apparent on start (dma_debug check_sync) with CONFIG_DMAR=n is gone. 2) W/o the above patch, I was getting sky2 DMAR errors and subsequent TX hangs requiring reboot to clear. The hangs happened after at least 12 hours of uptime, and under RX load at the time of the hang. 3) With the above patch (and no other changes) I have not been able to recreate the crash - the system is stable.Btw, could you remind us if during last dmar bugs jumbo frames might have been used or maybe mtu was changed, and the current test setting?I've hit this with and without Jumbo frames enabled. Last couple of recreations were with mtu = 1500, which is how I'm running now.quoted
quoted
I have been following the discussion about the DMA api would suggest that the length issue when DMAR is enabled is less innocuous than previously believed.Actually, the last conclusions are - it's more innocuous than ever believed, and I completely agree with this (at least until the next week ;-).I stand grammatically corrected.
I didn't mean anything grammatical, sorry! (Except, it's equally complex ;-) Jarek P.