Re: [PATCH 2/13] bridge: Allow tail-call on br_pass_frame_up
From: David Miller <davem@davemloft.net>
Date: 2010-02-27 11:14:33
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Fri, 26 Feb 2010 23:35:07 +0800
quoted hunk ↗ jump to hunk
@@ -20,9 +20,9 @@ /* Bridge group multicast address 802.1d (pg 51). */ const u8 br_group_address[ETH_ALEN] = { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x00 }; -static void br_pass_frame_up(struct net_bridge *br, struct sk_buff *skb) +static int br_pass_frame_up(struct sk_buff *skb) { - struct net_device *indev, *brdev = br->dev; + struct net_device *indev, *brdev = BR_INPUT_SKB_CB(skb)->brdev;
You use this new BR_INPUT_SKB_CB() here in patch #2, but you only start setting ->brdev it in patch #4. This breaks things and makes your patch series non-bisectable. Please fix, thanks.