Thread (18 messages) 18 messages, 3 authors, 2010-02-27

RE: [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack

From: Sjur Brændeland <hidden>
Date: 2010-02-27 10:20:24

David Miller wrote:
quoted
Hi Marcel.
quoted
quoted
CHANGE LOG:
Based on review comments from David Miller and Marcel Holtmann on the
previous patch set submitted the 16 February the following changes
have been done: 
- Removed ifdef __cplusplus from caif_socket.h
- Use socket level SOL_IP for socket options SO_PRIORITY and
SO_BINDTODEVICE
are you sure it is not better to use SOL_SOCKET here. At least
according to man 7 socket this would make a lot more sense. My point
in actually using SO_PRIORITY and SO_BINDTODEVICE is to use standard
socket options that are already used by everybody else. So they know
what to expect.    
Yes, this makes sense. I'll update this.
Please fix this up and resubmit your patch series so I can add
it to the net-next-2.6 tree.
I have sent a V4 patch-set, fixing the review comments on the 
V3 patch-set. But there are still review comments coming in.

Unfortunately, I am traveling until Thursday this week, without Internet access,
so if you would like me to resubmit again I will not be able to do that before
Thursday or Friday this week.

BR/Sjur
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help