From: Sjur Brændeland <redacted>
Date: Tue, 23 Feb 2010 08:39:52 +0100
Hi Marcel.
quoted
quoted
CHANGE LOG:
Based on review comments from David Miller and Marcel Holtmann on the
previous patch set submitted the 16 February the following changes
have been done:
- Removed ifdef __cplusplus from caif_socket.h
- Use socket level SOL_IP for socket options SO_PRIORITY and
SO_BINDTODEVICE
are you sure it is not better to use SOL_SOCKET here. At least
according to man 7 socket this would make a lot more sense. My point
in actually using SO_PRIORITY and SO_BINDTODEVICE is to use standard
socket options that are already used by everybody else. So they know
what to expect.
Yes, this makes sense. I'll update this.
Please fix this up and resubmit your patch series so I can add
it to the net-next-2.6 tree.