Re: [PATCH] isa-skelton: Remove a wrong netif_wake_queue() call
From: Jeff Garzik <hidden>
Date: 2010-02-26 17:03:54
On 02/24/2010 11:00 AM, Atsushi Nemoto wrote:
quoted hunk ↗ jump to hunk
The netif_wake_queue() is called correctly (i.e. only on !txfull condition) from net_tx(). So Unconditional call to the netif_wake_queue() here is wrong. This might cause calling of start_xmit routine on txfull state and trigger tx-ring overflow. This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687. Signed-off-by: Atsushi Nemoto<redacted> --- drivers/net/isa-skeleton.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/drivers/net/isa-skeleton.c b/drivers/net/isa-skeleton.c index 04d0502..3f33c90 100644 --- a/drivers/net/isa-skeleton.c +++ b/drivers/net/isa-skeleton.c@@ -536,7 +536,6 @@ static irqreturn_t net_interrupt(int irq, void *dev_id) /* Transmit complete. */ net_tx(dev); np->stats.tx_packets++; - netif_wake_queue(dev); } #endif
I would suggest deleting this "driver" entirely... Any new drivers remotely like ISA would use the platform API and look more like a PCI driver. Jeff