Thread (4 messages) 4 messages, 3 authors, 2010-02-26

Re: [PATCH] isa-skelton: Remove a wrong netif_wake_queue() call

From: David Miller <davem@davemloft.net>
Date: 2010-02-26 09:51:21

From: Atsushi Nemoto <redacted>
Date: Thu, 25 Feb 2010 01:00:17 +0900
The netif_wake_queue() is called correctly (i.e. only on !txfull
condition) from net_tx().  So Unconditional call to the
netif_wake_queue() here is wrong.  This might cause calling of
start_xmit routine on txfull state and trigger tx-ring overflow.

This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687.

Signed-off-by: Atsushi Nemoto <redacted>
Applied.

Please reference commits by also making mention of the commit
log message header line.  This way when a patch is backported
into another tree, people can still find it even if the
SHA1 ID is different.  For exmaple, I fixed the above to
read:

    This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687
    ("tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON").

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help