On 02/26/2010 08:56 AM, Jeff Garzik wrote:

However, perhaps consider the following patch for returning n-tuple
count, for four reasons:

1) space in ethtool_drvinfo is limited

2) the patch below permits trivial string set addition, without
ABI changes beyond adding a new ETH_SS_xxx constant.

3) the patch below permits direct access to ops->get_sset_count(),
rather than implicit access via ethtool_drvinfo

4) ethtool_drvinfo interface does not permit indication of
ops->get_sset_count() failure, versus returning zero value. The
patch below does so, via output sset_mask.

WARNING: this patch is compile-tested only.

NOTE: I added a cosmetic fix to ETHTOOL_[GS]RXNTUPLE constants, making
their indentation consistent with the rest of the list of constants.

Signed-off-by: Jeff Garzik <redacted>

With, perhaps, a note like the attached as a reminder to folks about 
future additions.