Re: [net-next-2.6 PATCH] ethtool: Add n-tuple string length to drvinfo and return it
From: Jeff Garzik <hidden>
Date: 2010-02-26 13:05:22
On 02/26/2010 07:20 AM, David Miller wrote:
From: Jeff Kirsher<redacted> Date: Fri, 26 Feb 2010 03:54:20 -0800quoted
From: Peter Waskiewicz<redacted> The drvinfo struct should include the number of strings that get_rx_ntuple will return. It will be variable if an underlying driver implements its own get_rx_ntuple routine, so userspace needs to know how much data is coming. Signed-off-by: Peter P Waskiewicz Jr<redacted> Signed-off-by: Jeff Kirsher<redacted>Applied.
NAK. Did you even read the patch? We don't increase the size of struct ethtool_drvinfo, _especially_ by sticking struct members into the middle of the struct. What do you think 'reserved' is for??? Jeff