Thread (57 messages) 57 messages, 10 authors, 2010-01-16

Re: [PATCH] sky2: safer transmit ring cleaning (v4)

From: Stephen Hemminger <hidden>
Date: 2010-01-14 17:53:10

On Thu, 14 Jan 2010 10:14:45 +0000
Jarek Poplawski [off-list ref] wrote:
This makes it safe, but it still resembles the "short term fix"
according do David's opinion.

This change seems to affect dev->stats too. Since they are not
updated in sky2_tx_clean(). Btw, I hope "&" is some optimization
because it's less readable than "&&".
Stats don't matter for packets flushed during device reset.

The & is because in the most common case device is up,
and we don't want the additional conditional branch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help