On Tue, Jan 12, 2010 at 10:13:06AM -0800, Stephen Hemminger wrote:

On Tue, 12 Jan 2010 19:04:30 +0100
Jarek Poplawski [off-list ref] wrote:

quoted

On Tue, Jan 12, 2010 at 08:15:13AM -0800, Stephen Hemminger wrote:

quoted

This code makes transmit path and transmit reset safer by:
  * adding memory barrier before checking available ring slots
  * reseting state of tx ring elements after free
  * seperate cleanup function from ring done function
  * removing mostly unused tx_next element  

Does this patch prevent re-enabling tx after netif_device_detach(),
e.g. when sky2_detach() and sky2_tx_done() run at the same time on
different cpus?

Yes.
The napi is disabled during the detach so transmit completion can
not be done during that period.

Could you point me where exactly the napi is disabled, probably I
missed this?

Jarek P.