Re: [PATCH 06/31] Constify struct e1000_mac_operations for 2.6.32 v1

2009/12/4 Emese Revfy [off-list ref]:

Stephen Rothwell wrote:

quoted

Hi Emese,

On Sat, 05 Dec 2009 01:03:03 +0100 Emese Revfy [off-list ref] wrote:

quoted

--- a/drivers/net/e1000e/82571.c
+++ b/drivers/net/e1000e/82571.c

@@ -212,6 +212,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter)

 {
     struct e1000_hw *hw = &adapter->hw;
     struct e1000_mac_info *mac = &hw->mac;
+    /* cannot be const */
     struct e1000_mac_operations *func = &mac->ops;

Adding to the comment to say why it can't be const may allow us to fix
this later ...

Ok, in the next patch series I will explain each case.
--

Also, please sync up your patches with what is in Dave's net-next-2.6
tree, because some of the changes made no longer apply since the code
was either changed or removed.

-- 
Cheers,
Jeff