Thread (3 messages) flat view 3 messages, 3 authors, 2009-12-05

Re: [PATCH 06/31] Constify struct e1000_mac_operations for 2.6.32 v1

From: Emese Revfy <hidden>
Date: 2009-12-05 01:17:10
Also in: lkml

Stephen Rothwell wrote:
Hi Emese,

On Sat, 05 Dec 2009 01:03:03 +0100 Emese Revfy [off-list ref] wrote:
quoted
--- a/drivers/net/e1000e/82571.c
+++ b/drivers/net/e1000e/82571.c
@@ -212,6 +212,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter)
 {
 	struct e1000_hw *hw = &adapter->hw;
 	struct e1000_mac_info *mac = &hw->mac;
+	/* cannot be const */
 	struct e1000_mac_operations *func = &mac->ops;
Adding to the comment to say why it can't be const may allow us to fix
this later ...
Ok, in the next patch series I will explain each case.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help