On Mon, 02 Nov 2009 00:07:56 -0800 (PST)
David Miller [off-list ref] wrote:

From: Stephen Hemminger <redacted>
Date: Thu, 29 Oct 2009 15:24:08 -0700

quoted

-	if (dev->flags & IFF_LOOPBACK || dev->type != ARPHRD_ETHER)
+	/* Don't allow bridging non ethernet like devices */
+	if (dev->flags & IFF_LOOPBACK
+	    || dev->type != ARPHRD_ETHER
+	    || dev->addr_len != ETH_ALEN)

Please format this as:

quoted

+	if (dev->flags & IFF_LOOPBACK ||
+	    dev->type != ARPHRD_ETHER ||
+	    dev->addr_len != ETH_ALEN)

What you're doing in the patch follows the GNU coding standards, no
the kernel ones. :-)

Sure, I never saw which side to put conditionals as part of coding standard document.

--