Re: [RFC] bridge: check address size
From: David Miller <davem@davemloft.net>
Date: 2009-11-02 08:07:32
From: David Miller <davem@davemloft.net>
Date: 2009-11-02 08:07:32
From: Stephen Hemminger <redacted> Date: Thu, 29 Oct 2009 15:24:08 -0700
- if (dev->flags & IFF_LOOPBACK || dev->type != ARPHRD_ETHER) + /* Don't allow bridging non ethernet like devices */ + if (dev->flags & IFF_LOOPBACK + || dev->type != ARPHRD_ETHER + || dev->addr_len != ETH_ALEN)
Please format this as:
+ if (dev->flags & IFF_LOOPBACK || + dev->type != ARPHRD_ETHER || + dev->addr_len != ETH_ALEN)
What you're doing in the patch follows the GNU coding standards, no the kernel ones. :-)