Thread (8 messages) 8 messages, 5 authors, 2009-09-25

Re: [RFC] skb align patch

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-09-25 22:18:49

Thomas Graf [off-list ref] wrote:
As I pointed out to Herbert already, this alignment change may actually
make things worse or even break things as long as compare_ether_header()
used in __napi_gro_receive() expects the IP header to be aligned to 4
bytes. That can be fixed of course, just wanted to mention it.
Well this particular patch doesn't because x86-64 is fine with
unaligned access :)

But yeah we need to fix up GRO to not do that for other arches.
It's on my list.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help