Thread (8 messages) 8 messages, 5 authors, 2009-09-25

Re: [RFC] skb align patch

From: Thomas Graf <hidden>
Date: 2009-09-23 05:47:48

On Mon, Sep 21, 2009 at 10:29:40PM -0700, David Miller wrote:
The alignment in this patch is a real big deal for 64 byte forwarding
tests, where the entire packet is a whole PCI-E cacheline.  But not
if it isn't aligned properly.
As I pointed out to Herbert already, this alignment change may actually
make things worse or even break things as long as compare_ether_header()
used in __napi_gro_receive() expects the IP header to be aligned to 4
bytes. That can be fixed of course, just wanted to mention it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help