On Thu, 27 Aug 2009 02:26:55 am Michael S. Tsirkin wrote:

On Tue, Aug 25, 2009 at 04:16:34PM +0300, Michael S. Tsirkin wrote:

quoted

quoted

quoted

+	/* If they don't want an interrupt, don't send one, unless empty. */
+	if ((flags & VRING_AVAIL_F_NO_INTERRUPT) && vq->inflight)
+		return;

And I wouldn't support notify on empty at all, TBH.

If I don't, virtio net in guest uses a timer, which might be expensive.
Will need to check what this does.

quoted

 It should
definitely be conditional on the guest accepting the NOTIFY_ON_EMPTY
feature.

lguest does not do it this way though, do it?

Does when a patch in my current queue is applied though.

Thanks,
Rusty.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>