Re: [PATCHv4 2/2] vhost_net: a kernel-level virtio server
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2009-08-26 17:00:14
Also in:
kvm, linux-mm, lkml
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2009-08-26 17:00:14
Also in:
kvm, linux-mm, lkml
On Tue, Aug 25, 2009 at 04:16:34PM +0300, Michael S. Tsirkin wrote:
quoted
quoted
+ /* If they don't want an interrupt, don't send one, unless empty. */ + if ((flags & VRING_AVAIL_F_NO_INTERRUPT) && vq->inflight) + return;And I wouldn't support notify on empty at all, TBH.If I don't, virtio net in guest uses a timer, which might be expensive. Will need to check what this does.quoted
It should definitely be conditional on the guest accepting the NOTIFY_ON_EMPTY feature.
lguest does not do it this way though, do it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>