Re: [PATCH v2 2/2] IPVS: use pr_err and friends instead of IP_VS_ERR and friends
From: Joe Perches <joe@perches.com>
Date: 2009-07-28 20:57:00
Also in:
lkml, lvs-devel
On Tue, 2009-07-28 at 22:35 +0200, Hannes Eder wrote:
Since pr_err and friends is used instead of printk there is not point
in keeping IP_VS_ERR and friends.
+ pr_err("Schedule: port zero only supported "
+ "in persistent services, "
+ "check your ipvs configuration\n");You might consider ignoring the checkpatch 80 char limit here and consolidate the message into a single string. It helps when grepping.
quoted hunk ↗ jump to hunk
@@ -377,8 +377,8 @@ static int ip_vs_svc_hash(struct ip_vs_service *svc) static int ip_vs_svc_unhash(struct ip_vs_service *svc) { if (!(svc->flags & IP_VS_SVC_F_HASHED)) { - IP_VS_ERR("ip_vs_svc_unhash(): request for unhash flagged, " - "called from %p\n", __builtin_return_address(0)); + pr_err("ip_vs_svc_unhash(): request for unhash flagged, " + "called from %p\n", __builtin_return_address(0));
Maybe use something like: "%s(): <foo> called from %pf", __func__, __builtin_return_address(0)