On Mon, Jul 27, 2009 at 20:14, Jan Engelhardt[off-list ref] wrote:

On Monday 2009-07-27 15:46, Hannes Eder wrote:

quoted

Now all printk messages from IPVS are prefixed with "IPVS:".

+#define EnterFunction(level)                                                 \
+      do {                                                                   \
+              if (level <= ip_vs_get_debug_level())                          \
+                      printk(KERN_DEBUG "IPVS: Enter: %s, %s line %i\n",     \
+                              __func__, __FILE__, __LINE__);                 \
+      } while (0)
+#define LeaveFunction(level)                                                 \
+      do {                                                                   \
+              if (level <= ip_vs_get_debug_level())                          \
+                      printk(KERN_DEBUG "IPVS: Leave: %s, %s line %i\n",     \
+                              __func__, __FILE__, __LINE__);                 \
+      } while (0)

I think you should rather make use of pr_fmt:

<before any #includes>
#define pr_fmt(x) "IPVS: " x

And then use pr_<level>("Elvis has left the building") in code. This
will add IPVS: automatically to all pr_* calls, alleviating the need
to manually type it into all printks.

I like this idea.  I'll come up with an extra patch, it does not fit
into this series anyway.

Of course, if you only want it for the two defines here, scrap
my idea :)

Cheers,
-Hannes