Re: [RFC][PATCH 1/5] IPVS: prefix EnterFunction and LeaveFunction msg with "IPVS:"
From: Jan Engelhardt <hidden>
Date: 2009-07-27 18:14:33
Also in:
lkml, lvs-devel, netfilter-devel
From: Jan Engelhardt <hidden>
Date: 2009-07-27 18:14:33
Also in:
lkml, lvs-devel, netfilter-devel
On Monday 2009-07-27 15:46, Hannes Eder wrote:
Now all printk messages from IPVS are prefixed with "IPVS:".
+#define EnterFunction(level) \
+ do { \
+ if (level <= ip_vs_get_debug_level()) \
+ printk(KERN_DEBUG "IPVS: Enter: %s, %s line %i\n", \
+ __func__, __FILE__, __LINE__); \
+ } while (0)
+#define LeaveFunction(level) \
+ do { \
+ if (level <= ip_vs_get_debug_level()) \
+ printk(KERN_DEBUG "IPVS: Leave: %s, %s line %i\n", \
+ __func__, __FILE__, __LINE__); \
+ } while (0)
I think you should rather make use of pr_fmt:
<before any #includes>
#define pr_fmt(x) "IPVS: " x
And then use pr_<level>("Elvis has left the building") in code. This
will add IPVS: automatically to all pr_* calls, alleviating the need
to manually type it into all printks.
Of course, if you only want it for the two defines here, scrap
my idea :)