Thread (55 messages) flat view 55 messages, 9 authors, 2009-06-20

Re: [bug] __nf_ct_refresh_acct(): WARNING: at lib/list_debug.c:30 __list_add+0x7d/0xad()

From: David Miller <davem@davemloft.net>
Date: 2009-06-17 11:35:42
Also in: lkml

From: Ingo Molnar <redacted>
Date: Wed, 17 Jun 2009 13:08:03 +0200
* Eric Dumazet [off-list ref] wrote:
quoted
IPS_CONFIRMED_BIT is set under nf_conntrack_lock (in __nf_conntrack_confirm()),
we probably want to add a synchronisation under ct->lock as well,
or __nf_ct_refresh_acct() could set ct->timeout.expires to extra_jiffies,
while a different cpu could confirm the conntrack.

Following patch as RFC
A quick test suggests that it seems to works here - thanks Eric!
Patrick, please take a quick look at Eric's fix.  I'd like to
apply it quickly if it looks good to you.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help