Re: [PATCH] fix NULL pointer + success return in route lookup path

From: Jarek Poplawski <redacted>
Date: Sat, 20 Jun 2009 18:39:25 +0200

Jarek Poplawski wrote, On 06/20/2009 02:37 PM:

quoted

Neil Horman wrote, On 06/19/2009 07:18 PM:

quoted

Don't drop route if we're not caching	

...

quoted

quoted

 route.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index cd76b3c..65b3a8b 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c

@@ -1085,8 +1085,16 @@ restart:
 	now = jiffies;
 
 	if (!rt_caching(dev_net(rt->u.dst.dev))) {
-		rt_drop(rt);

One more question: if this rt is assigned to an skb, there is only
skb_dst_drop() in kfree_skb(), but it seems we skip rt_free() part,
or I miss something?

This whole code path was buggy, if it returns success it should
do as the normal success code path does which is assign for
non-SKB case to *rp, or skb_dst_set().