Re: Re-submit [PATCH 1/1] ethtool: Expose MDI-X status
From: Ben Hutchings <hidden>
Date: 2009-06-10 19:22:27
Attachments
- 0001-ethtool-Expose-MDI-X-status.patch [application/mbox] 1883 bytes · preview
From: Ben Hutchings <hidden>
Date: 2009-06-10 19:22:27
On Wed, 2009-06-10 at 12:11 -0700, Chaitanya Lala wrote:
The MDI-X status is a useful tool for diagnosing network connectivity issues. We expose MDI-X status as a tri-state value status which drivers can optionally implement. Signed-off-by: Chaitanya Lala <redacted> Signed-off-by: Arthur Jones <redacted> --- ethtool-copy.h | 8 +++++++- ethtool.c | 13 +++++++++++++ 2 files changed, 20 insertions(+), 1 deletions(-)diff --git a/ethtool-copy.h b/ethtool-copy.h index 3ca4e2c..48fb1d3 100644 --- a/ethtool-copy.h +++ b/ethtool-copy.h@@ -26,7 +26,8 @@ struct ethtool_cmd { __u32 maxtxpkt; /* Tx pkts before generating tx int */ __u32 maxrxpkt; /* Rx pkts before generating rx int */ __u16 speed_hi; - __u16 reserved2; + __u8 is_mdix; + __u8 reserved2; __u32 reserved[3]; };@@ -416,6 +417,11 @@ struct ethtool_rxnfc { #define AUTONEG_DISABLE 0x00 #define AUTONEG_ENABLE 0x01 +/* Mode MDI or MDI-X */ +#define MDI_INVALID 0x00 +#define MDI 0x01 +#define MDI_X 0x02 + /* Wake-On-Lan options. */ #define WAKE_PHY (1 << 0) #define WAKE_UCAST (1 << 1)
[...] This doesn't match the changes in <linux/ethtool.h>. I'm attaching the patch I applied locally for testing MDI-X reporting in sfc. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.