David Miller [off-list ref] wrote on 25/03/2009 22:40:41:

From: Eric Dumazet <redacted>
Date: Wed, 25 Mar 2009 15:04:26 +0100

quoted

Joakim Tjernlund a écrit :

quoted

+   /* Tx event processing */
+   spin_lock(&ugeth->lock);
+   for (i = 0; i < ug_info->numQueuesTx; i++) {
+      ucc_geth_tx(ugeth->dev, i);
+   }
+   spin_unlock(&ugeth->lock);
+

Why tx completions dont change "howmany" ?
It seems strange you changed UCC_GETH_DEV_WEIGHT if not taking into 

account tx event above...

He should leave howmany alone for TX work and use a weight
value of 64 just like most other drivers in the tree do.

OK, will change this to 64.

Due to the abuse and random ignorant fiddling of the
weight value, I am going to make it something the core
rather than drivers choose.

Good, I had a hard time finding info how one should use it anyway.