David Miller [off-list ref] wrote on 25/03/2009 22:40:41:

=20
From: Eric Dumazet <redacted>
Date: Wed, 25 Mar 2009 15:04:26 +0100
=20

quoted

Joakim Tjernlund a =E9crit :

quoted

+   /* Tx event processing */
+   spin=5Flock(&ugeth->lock);
+   for (i =3D 0; i < ug=5Finfo->numQueuesTx; i++) {
+      ucc=5Fgeth=5Ftx(ugeth->dev, i);
+   }
+   spin=5Funlock(&ugeth->lock);
+

=20
Why tx completions dont change "howmany" ?
It seems strange you changed UCC=5FGETH=5FDEV=5FWEIGHT if not taking in=

to=20
account tx event above...

=20
He should leave howmany alone for TX work and use a weight
value of 64 just like most other drivers in the tree do.

OK, will change this to 64.

=20
Due to the abuse and random ignorant fiddling of the
weight value, I am going to make it something the core
rather than drivers choose.

Good, I had a hard time finding info how one should use it anyway.=20