From: Patrick McHardy <redacted>
Date: Tue, 03 Mar 2009 00:03:00 +0100

David Miller wrote:

quoted

From: Patrick McHardy <redacted>
Date: Mon, 02 Mar 2009 23:20:49 +0100

quoted

This looks like its working fine. Despite the non-desirable active
spinning, this seems like the best fix (actually much simpler than
I expected to be possible) at this time. If we just could avoid
the spinning when unnecessary, it would be perfect :)

Could you give that "not actually in-progress" detection a shot?
I don't like the spinning either.

I tried this morning, the problem is that its always the sysctl
handler which will run into the deadlock first, but there is no
reliable indication to avoid it other than that the RTNL is
already held. The problem is that the sysctl interface puts the
process holding the RTNL to sleep and allows a process requiring
it to run. Any different synchronization attempt will have the
same problem, it seems you simply can't hold any locks while
unregistering sysctls.

Ok, I applied Stephen's patches then...