Thread (40 messages) 40 messages, 3 authors, 2009-03-02

Re: [PATCH net-next 14/17] tcp: remove pointless .dsack code

From: David Miller <davem@davemloft.net>
Date: 2009-03-02 11:57:51

From: "Ilpo Järvinen" <redacted>
Date: Mon, 2 Mar 2009 13:54:17 +0200 (EET)
We'll be dirty it anyway (not that I check), the first "real" statement
in tcp_rcv_established is:

	tp->rx_opt.saw_tstamp = 0;

...that'll land on the same dword. :-/

I suppose the blocks are there just because they had more complexity 
inside when they had to calculate the eff_sacks too (maybe it would
have been better to just remove them in that drop-patch so you would
have had less head-ache :-)).
That sounds like a good commit log entry for when you resubmit
this patch :-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help