Re: [PATCH 0/26] Reliable Datagram Sockets (RDS), take 2
From: Andrew Grover <hidden>
Date: 2009-02-25 18:43:28
On Tue, Feb 24, 2009 at 11:28 PM, David Miller [off-list ref] wrote:
This makes RDMA too much of a first-class citizen in the networking stack. That's a blocker for me.
RDS is not an RDMA protocol, it is a protocol that supports RDMA. RDS is not an IB protocol, it is a protocol that supports IB transport. RDS's reliable-datagram socket implementation has a modular interface to the transport (e.g. tcp, udp, or ib) and works fine over transports that do not support RDMA. (Most users also do not use RDMA.) OK so we have: 1) RDS socket code must go in net/rds, it's socket code 2) RDS core rdma support move to drivers/infiniband? 3) RDS IB/iwarp transport keep the non-RDMA support in net/rds or move to d/i? It's not RDMA it's IB 4) IB/iwarp transport's rdma support move to d/i 5) RDS TCP transport (impl. but not incl. in patchset) net/rds 6) RDS UDP/DCB transport (not impl. yet) net/rds Does this look right? Right now it sounds like you're saying 1, 5, and 6 go in net/rds, 2-4 go in drivers/infiniband. I'd personally prefer to not split it up, or to split it on the natural core/transport boundary, but I can make it work whatever you decide. :-)
Furthermore the port you've choosen for the protocol is arbitrary, not properly allocated with the appropriate standards committee, and therefore could conflict with something other people are using.
I'm sure allocating the port won't be too big an issue. Regards -- Andy