Re: [PATCH 01/02] hso patch to fix a -EIO from opening a hso serial device
From: Alan Cox <hidden>
Date: 2009-01-14 11:38:28
Also in:
linux-serial
Subsystem:
hso 3g modem driver, networking drivers, the rest, usb networking drivers · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2009-01-14 · Re: [PATCH 01/02] hso patch to fix a -EIO from opening a hso serial device · Alan Cox <hidden>
- 2009-01-14 · Re: [PATCH 01/02] hso patch to fix a -EIO from opening a hso serial device · Denis Joseph Barrow <hidden>
- 2009-01-14 · [PATCH 01/02] hso patch to fix a -EIO from opening a hso serial device · Denis Joseph Barrow <hidden>
On Wed, 14 Jan 2009 12:22:31 +0100 Denis Joseph Barrow [off-list ref] wrote:
Hi All, This is an important patch the linux-2.6.29-rc1 driver with itworks much better than it did.
How about this. tty: Fix a kref leak in the HSO driver on re-open From: Alan Cox <redacted> --- drivers/net/usb/hso.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index c4918b8..9df04dd 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c@@ -1297,6 +1297,7 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp) /* setup */ spin_lock_irq(&serial->serial_lock); tty->driver_data = serial; + tty_kref_put(serial->tty); serial->tty = tty_kref_get(tty); spin_unlock_irq(&serial->serial_lock); --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html