Re: [PATCH 01/02] hso patch to fix a -EIO from opening a hso serial device
From: Denis Joseph Barrow <hidden>
Date: 2009-01-14 12:40:34
Also in:
linux-serial
Hi Alan, Your fix works too I suspect better than mine & since you've a better idea of what you are doing with tty layer than I do we'll stick with your fix. Do you want me to switch off the low latency stuff in the driver? I also need to investigate the tty_kref_put & tty_kref_get & when it was added to the kernel so I can fix stuff for our internal driver Alan Cox wrote:
quoted hunk
On Wed, 14 Jan 2009 12:22:31 +0100 Denis Joseph Barrow [off-list ref] wrote:quoted
Hi All, This is an important patch the linux-2.6.29-rc1 driver with itworks much better than it did.How about this. tty: Fix a kref leak in the HSO driver on re-open From: Alan Cox <redacted> --- drivers/net/usb/hso.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index c4918b8..9df04dd 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c@@ -1297,6 +1297,7 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp) /* setup */ spin_lock_irq(&serial->serial_lock); tty->driver_data = serial; + tty_kref_put(serial->tty); serial->tty = tty_kref_get(tty); spin_unlock_irq(&serial->serial_lock);
-- best regards, D.J. Barrow Linux Kernel Developer Option NV, Gaston Geenslaan 14, 3001 Leuven, Belgium T: +32 16 311 621 F: +32 16 207 164 d.barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org www.option.com Disclaimer: http://www.option.com/company/disclaimer.shtml -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html