Thread (52 messages) flat view 52 messages, 10 authors, 2008-12-16

Re: [PATCH 6/6] fs: Introduce kern_mount_special() to mount special vfs

From: Christoph Hellwig <hch@infradead.org>
Date: 2008-11-27 09:53:40
Also in: lkml

On Thu, Nov 27, 2008 at 12:32:59AM +0100, Eric Dumazet wrote:
This function arms a flag (MNT_SPECIAL) on the vfs, to avoid
refcounting on permanent system vfs.
Use this function for sockets, pipes, anonymous fds.
special is not a useful name for a flag, by definition everything that
needs a flag is special compared to the version that doesn't need a
flag.

The general idea of skippign the writer counts makes sense, but please
give it a descriptive name that explains the not unmountable thing.
And please kill your kern_mount wrapper and just set the flag manually.

Also I think it should be a superblock flag, not a mount flag as you
don't want thse to differ for multiple mounts of the same filesystem.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help