Re: [PATCH 1/5] dccp: Mechanism to resolve CCID dependencies
From: David Miller <davem@davemloft.net>
Date: 2008-11-17 06:50:41
From: David Miller <davem@davemloft.net>
Date: 2008-11-17 06:50:41
From: Gerrit Renker <redacted> Date: Sat, 15 Nov 2008 13:11:15 +0100
This adds a hook to resolve features whose value depends on the choice of CCID. It is done at the server since it can only be done after the CCID values have been negotiated; i.e. the client will add its CCID preference list on the Change options sent in the Request, which will be reconciled with the local preference list of the server. The concept is documented on http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/feature_negotiation/\ implementation_notes.html#ccid_dependencies Signed-off-by: Gerrit Renker <redacted> Acked-by: Ian McDonald <redacted>
Applied.
+ list_for_each_entry(entry, fn_list, node) + if (entry->feat_num == feat_num && entry->is_local == is_local) + return entry; + else if (entry->feat_num > feat_num) + break;
Personally, I would have put braces around this basic block.