Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference
From: Jeff Garzik <hidden>
Date: 2008-09-03 14:12:44
From: Jeff Garzik <hidden>
Date: 2008-09-03 14:12:44
Krzysztof Halasa wrote:
Adrian Bunk [off-list ref] writes:quoted
--- a/drivers/net/wan/hdlc_x25.c +++ b/drivers/net/wan/hdlc_x25.c@@ -163,10 +163,8 @@ static void x25_close(struct net_device *dev) static int x25_rx(struct sk_buff *skb) { - if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) { - skb->dev->stats.rx_dropped++; + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) return NET_RX_DROP; - }Right, thanks... though I will update the stats anyway.
In terms of patches... what does this mean? Does this mean you are taking Adrian's patch, and updating it? Sending a follow-up patch? Ack'ing Adrian's patch? I don't want to hold this back due to lack of stat update...