Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: 2008-08-31 17:08:39
Adrian Bunk [off-list ref] writes:
quoted hunk ↗ jump to hunk
--- a/drivers/net/wan/hdlc_x25.c +++ b/drivers/net/wan/hdlc_x25.c@@ -163,10 +163,8 @@ static void x25_close(struct net_device *dev) static int x25_rx(struct sk_buff *skb) { - if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) { - skb->dev->stats.rx_dropped++; + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) return NET_RX_DROP; - }
Right, thanks... though I will update the stats anyway. -- Krzysztof Halasa