Thread (19 messages) 19 messages, 4 authors, 2008-08-04

Re: [PATCH] inet6: Fix paramater issue of inet6_csk_xmit

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-08-02 00:30:34

On Fri, Aug 01, 2008 at 10:50:17AM -0400, Vlad Yasevich wrote:
quoted
+	inet->pmtudisc = transport->param_flags & SPP_PMTUD_ENABLE ?
+			 IP_PMTUDISC_DO : IP_PMTUDISC_DONT;
If you insist on doing this, you need to save the old value and restore
it after ip_queue_xmit(). 

The reason is that PMTU discovery change on a specific transport or
association should not affect the socket, since there could be multiple
associations on a given socket.  Each association has it's own control.
Yes but they'll all pass through here so it'll get set to the
appropriate value.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help