Thread (19 messages) 19 messages, 4 authors, 2008-08-04

Re: [PATCH] inet6: Fix paramater issue of inet6_csk_xmit

From: David Miller <davem@davemloft.net>
Date: 2008-08-01 09:18:25

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 01 Aug 2008 17:11:01 +0800
Wei Yongjun [off-list ref] wrote:
quoted
inet6_csk_xmit() just be used by tcp and dccp:
1042 net/dccp/ipv6.c      .queue_xmit       = inet6_csk_xmit
1853 net/ipv6/tcp_ipv6.c     .queue_xmit       = inet6_csk_xmit,

And used always with ipfragok = 0.
139 net/dccp/output.c         err = icsk->icsk_af_ops->queue_xmit(skb, 0);
626 net/ipv4/tcp_output.c     err = icsk->icsk_af_ops->queue_xmit(skb, 0);

I can not find any place used inet6_csk_xmit() with ipfragok = 1.

So I think it is safe to apply this patch. Or maybe this paramater is 
useless.
No we should get rid of the ipfragok argument if noone uses it.
SCTP calls ip_queue_xmit() and ip6_xmit() directly with it's ipfragok
argument, so it is used for these functions.

As a result ->icsk_af_ops->queue_xmit() needs to have arguments
at least matching those function's prototypes.




Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help